[PATCH] D71957: [llvm-size] print a blank line between archieve members when using sysv format

Jim Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 30 00:25:19 PST 2019


Jim added a comment.

The testcases tools/llvm-size/archive.test, tools/llvm-size/multiple-inputs.test and tools/llvm-size/radix.test 
fail due to this patch. Could you update this testcases? You can try to execute command "ninja check-all -j32".



================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:449
     outs() << format(fmt.str().c_str(), static_cast<const char *>("Total"),
-                     total);
+                     total) << "\n";
   } else {
----------------
Put "<< "\n"" in the new line look better.

```
outs() << format... 
       << "\n";
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71957/new/

https://reviews.llvm.org/D71957





More information about the llvm-commits mailing list