[PATCH] D71826: [Coroutines] Remove corresponding phi values when apply simplifyTerminatorLeadingToRet

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 29 18:01:09 PST 2019


junparser added a comment.



In D71826#1797514 <https://reviews.llvm.org/D71826#1797514>, @modocache wrote:

> Sorry for the wait here, @junparser! I wanted to send my own patches out before looking at this one 😛
>
> This is really nice, thanks for the change! As per your test plan, I confirmed that with this patch, cppcoro issue https://github.com/lewissbaker/cppcoro/issues/109 no longer reproduces for me. The jump threading issue you describe must have been responsible for Clang hanging indefinitely when compiling that test file.
>
> I had one nitpick related to your test, please address it or not at your own discretion. This patch LGTM.


tks, I‘ll update the testcase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71826/new/

https://reviews.llvm.org/D71826





More information about the llvm-commits mailing list