[PATCH] D71620: [Attributor] AAValueConstantRange: Value range analysis using constant range

[Hideto Ueno via Phabricator via llvm-commits]

uenoku marked 5 inline comments as done.
uenoku added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5054
+    return false;
+  }
+
----------------
jdoerfert wrote:
> I don't think we have a test which checks the metadata, right? We should create one if possible or add a TODO here explaining why it's not possible yet.
I create a test for metadata(range.ll/test0-range-check.ll)


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:4141
 
+  bool askSimplifiedValueForAAValueConstantRange(Attributor &A) {
+    if (!getAssociatedValue().getType()->isIntegerTy())
----------------
I'll add a comment here later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71620/new/

https://reviews.llvm.org/D71620