[PATCH] D71960: [Attributor] AAUndefinedBehavior: AAValueSimplify in memory accessing instructions.

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 28 08:02:34 PST 2019


baziotis created this revision.
baziotis added reviewers: jdoerfert, uenoku.
Herald added subscribers: llvm-commits, arphaman, hiraditya.
Herald added a reviewer: sstefan1.
Herald added a project: LLVM.

Part of this patch is to fix the test cases that were failing when I had previously tried it. For the most test cases the only thing I had to is to increase the number
of expected iterations. I //assumed// that this is reasonable since now `AAValueSimplify` is queried by yet another AA. //However//, please verify if it is correct.
There's one test case that is //worrying//: `IPConstantProp/PR26044.ll`. With this patch, a from `undef` becomes load from `null` and I don't see the reason.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71960

Files:
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/test/Transforms/Attributor/ArgumentPromotion/2008-02-01-ReturnAttrs.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/2008-07-02-array-indexing.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/X86/attributes.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/X86/min-legal-vector-width.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/fp80.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/inalloca.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/profile.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/reserve-tbaa.ll
  llvm/test/Transforms/Attributor/ArgumentPromotion/sret.ll
  llvm/test/Transforms/Attributor/IPConstantProp/2009-09-24-byval-ptr.ll
  llvm/test/Transforms/Attributor/IPConstantProp/PR26044.ll
  llvm/test/Transforms/Attributor/align.ll
  llvm/test/Transforms/Attributor/internal-noalias.ll
  llvm/test/Transforms/Attributor/returned.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71960.235475.patch
Type: text/x-patch
Size: 13543 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191228/c83dcc14/attachment.bin>


More information about the llvm-commits mailing list