[PATCH] D54242: DebugInfo: Add a CU metadata attribute for use of DWARF ranges base address specifiers

[David Blaikie via Phabricator via llvm-commits]

dblaikie marked an inline comment as done.
dblaikie added inline comments.
Herald added a subscriber: ormris.


================
Comment at: llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp:1399
+        Record.size() <= 18 ? 0 : Record[18],
+        Record.size() <= 19 ? 0 : Record[19]);
 
----------------
aprantl wrote:
> @dblaikie Let me know if I'm just confused, but I don't think this works. The check on line 1383 rejects any records with a size of 20.
> Incidentally, serialization of the baseAddress flag isn't being tested in `test/Assembler/dicompileunit.ll`.
> 
Thanks! Addressed in c51b45e32ef7f35c11891f60871aa9c2c04cd991


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54242/new/

https://reviews.llvm.org/D54242