[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 27 16:44:57 PST 2019


baziotis updated this revision to Diff 235455.
baziotis added a comment.

- `Attributor::getPointerOperand()` and `getPointerOperandOfNonVolatile()`.
- Removed `AAValueSimplify` for memory accessing instructions.
- Updated test cases.

Notes:

1. As it seems, there are multiple instances of `getPointerOperand()` across LLVM. We should probably be careful and not name a function

like this, hence I put `getPointerOperand()` as a `static` method of `Attributor`. You may want to check this <http://lists.llvm.org/pipermail/llvm-dev/2018-February/120999.html>, although it's somewhat old and probably outdated.

2. @uenoku I updated the test cases according to what I thought they tried to test. Please verify that they're correct because I may very well have misinterpreted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71799/new/

https://reviews.llvm.org/D71799

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/test/Transforms/Attributor/IPConstantProp/PR26044.ll
  llvm/test/Transforms/Attributor/IPConstantProp/fp-bc-icmp-const-fold.ll
  llvm/test/Transforms/Attributor/IPConstantProp/solve-after-each-resolving-undefs-for-function.ll
  llvm/test/Transforms/Attributor/undefined_behavior.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71799.235455.patch
Type: text/x-patch
Size: 20281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191228/485e66fb/attachment.bin>


More information about the llvm-commits mailing list