[PATCH] D71930: [mlir][spirv] Add basic definitions for supporting availability

Mahesh Ravishankar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 27 13:15:45 PST 2019


mravishankar accepted this revision.
mravishankar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp:1
 //===- SPIRVSerializationGen.cpp - SPIR-V serialization utility generator -===//
 //
----------------
antiagainst wrote:
> mravishankar wrote:
> > Is there a reason to not have them in a separate file. The additions are completely independent here right?
> Wanted to keep all SPIR-V specific TableGen backend in one place. I think this is okay for now. 
Ok, wont try to push it. Wouldn't most of these methods to go into TblGen core infra?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71930/new/

https://reviews.llvm.org/D71930





More information about the llvm-commits mailing list