[PATCH] D71565: Make mangled_names.test and update_cc_test_checks.py work with Python 2.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 27 11:48:50 PST 2019


rnk added a comment.

I kind of wish we'd go back to the plain "#!/usr/bin/env python` version of the shebang. On Windows, because symlinks are not commonplace (they can be enabled, but are usually not), Python packages do not have versioned python binary names (python2.7, python3, etc). There is and has always been just `python.exe`.

If people want to add a startup version check to the test updating scripts so that the exit with a clear error message ("use Python 3"), IMO that would be the best solution. I want to live in a world where there is only one Python version at a time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71565/new/

https://reviews.llvm.org/D71565





More information about the llvm-commits mailing list