[PATCH] D71941: AMDGPU: Fix SI_IF lowering when the save exec reg has terminator uses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 27 10:43:59 PST 2019


arsenm created this revision.
arsenm added reviewers: alex-t, rampitec, nhaehnle.
Herald added subscribers: hiraditya, t-tye, tpr, dstuttard, yaxunl, wdng, jvesely, kzhuravl.
Herald added a project: LLVM.

Reverts part of 6524a7a2b9ca072bd7f7b4355d1230e70c679d2f. Since that
commit, the expansion was ignoring the actual save exec register
produced by the instruction, and looking at other instructions. I do
not understand why it was looking at other instructions, but relying
on this scan was wrong.

      

Fixes verifier errors after SI_IF is tail duplicated, which should be
correct to do. The results were fed into a phi, which was lowered to
the S_MOV_B64_term instructions.


https://reviews.llvm.org/D71941

Files:
  llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp
  llvm/test/CodeGen/AMDGPU/si-if-lower-user-terminators.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71941.235437.patch
Type: text/x-patch
Size: 6465 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191227/de8adfdc/attachment.bin>


More information about the llvm-commits mailing list