[PATCH] D71912: [mlir] Floating constants for import-llvm

[shraiysh via Phabricator via llvm-commits]

shraiysh added a comment.
Herald added a subscriber: antiagainst.

> I would also add an error message in cases where constant conversion failed and made sure the callers of getConstantAsAttr are aware that it can return null (there may be x86_fp80 and fp128 values, that are not supported in MLIR at all). Fine for a separate commit.

Sure!

> That's the side effect of Phabricator/Arcanist: it replaces the original author with whoever commits the patch. Apparently, it cannot show me the email of the original author due to some privacy concerns, so I cannot manually amend the commit unless the email is available somewhere else, e.g. in the signed-of-by field.

For future reference, is there anything I can do to make sure my name is shown in the author field?

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71912/new/

https://reviews.llvm.org/D71912