[PATCH] D71916: High-Level Code-Review Documentation Update

Chris Lattner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 26 20:10:29 PST 2019


lattner accepted this revision.
lattner added a comment.
This revision is now accepted and ready to land.

This looks really great to me, thank you for driving this!  I'd recommend giving this a couple of days for others to comment (as the doc itself suggest :-), given the global nature of the change.  Thanks!



================
Comment at: llvm/docs/CodeReview.rst:10
+ * Improve robustness and prevent the introduction of defects.
+ * Best leverage the experience of other contributors for each proposed change.
+
----------------
I'd recommend adding a fourth bullet, along the lines of:

* Help grow and develop new contributors, through mentorship by community leaders.


================
Comment at: llvm/docs/CodeReview.rst:122
+and after a week that community member has yet to respond, feel free to ping
+him or her, or alternatively, ask the original reviewer for further
+suggestions.
----------------
Recommend s/him or her/them/ to be inclusive of our nonbinary friends.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71916/new/

https://reviews.llvm.org/D71916





More information about the llvm-commits mailing list