[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 26 14:24:04 PST 2019


rnk added a comment.

I reverted the update_cc_* part of this patch in 287307a0c60b68099d5f9dd22ac1db2a42593533 <https://reviews.llvm.org/rG287307a0c60b68099d5f9dd22ac1db2a42593533>. Testing for python3 on PATH and assuming that it's going to work with no way for the user to disable the tests from cmake doesn't seem like a great approach. This essentially creates a test suite dependency on py3, and IIRC on llvm-dev we agreed we don't want that, we want to be able to check out, build, & test llvm without py3.

I would prefer that this reland as something that uses `config.python_executable` with a check for python 3 in cmake.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70660/new/

https://reviews.llvm.org/D70660





More information about the llvm-commits mailing list