[PATCH] D71780: [msan] Check qsort input.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 26 13:01:05 PST 2019


eugenis added a comment.

CompareOptionRecords checks that there are no duplicate options in the sorting comparator function.
I believe this is wrong, because I could not find a promise in POSIX nor in linux manpages that the comparator would never be called with the same object on both left and right hand side.

Nevertheless, I don't want sanitizers to enforce this peculiarity in the standard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71780/new/

https://reviews.llvm.org/D71780





More information about the llvm-commits mailing list