[PATCH] D71888: [mlir] Added llvm.resume in LLVM IR Dialect

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.
Herald added a subscriber: burmako.


================
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td:457
+  let verifier = [{
+    if(getNumOperands() != 1)
+      return emitOpError("expected exactly two successors");
----------------
ftynse wrote:
> The number of operands should be checked by declaring them in the "arguments" list with appropriate types. This will need another check to make sure the type matches that mentioned in some "landingpad", but that check can assume the "arguments"-based check passed.
> 
> Note that in MLIR, operation verifiers are not allowed to inspect sibling operations (since operations can be processed in parallel). So the type-match verifier should be implemented on the enclosing operation, likely in LLVMFuncOp.
> Note that in MLIR, operation verifiers are not allowed to inspect sibling operations (since operations can be processed in parallel). 

To clarify: this is only true for symbolic reference region-traversal: it is valid to traverse use-def chains in a verifier I believe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71888/new/

https://reviews.llvm.org/D71888