[PATCH] D71777: [RISCV][NFC] Deduplicate Atomic Intrinsic Definitions

Mon Dec 23 14:42:04 PST 2019

jrtc27 added inline comments.

================
Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:23
+
+  // T @llvm.<name>.T(any*, T, T, T imm);
+  class MaskedAtomicRMWFourArg<LLVMType itype>
----------------
jrtc27 wrote:
> This (and other lines like it) is slightly misleading as, given the llvm_anyptr_ty, it's an overloaded intrinsic, whose canonical name includes the specialisation (eg `llvm.foo.i8p0` for an `i8 *`, or `llvm.foo.i32p200` for an `i32 addrspace(200) *`). But perhaps that's ok, especially since the textual IR format allows you to drop the suffix and will infer it from the arguments.
`p0i8` and `p200i32`...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71777/new/

https://reviews.llvm.org/D71777