[PATCH] D71617: [WIP][NFC][Attributor] noalias attribute deduction fixme

pankaj gode via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 25 09:45:03 PST 2019


pgode updated this revision to Diff 235285.
pgode added a comment.
Herald added a subscriber: jfb.
Herald added a reviewer: sstefan1.

Tried addressing the comments in this patch.

- Created new methods for NoCaptureMaybeBeforeInstruction which returns true as of now. Using this method in the checkForAllUses method.
- Added additional parameter to checkForAllUses (initializing to nullptr). If this ptr is not null, then we check if use is reachable till this callsite instruction.
- Predicate checks in which case we should follow for use's user.
- checkForAllUses is called to check uses of argument. If it is valid/reachable use, then noalias deduction should happen.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71617/new/

https://reviews.llvm.org/D71617

Files:
  llvm/include/llvm/Transforms/IPO/Attributor.h
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/test/Transforms/Attributor/ArgumentPromotion/variadic.ll
  llvm/test/Transforms/Attributor/IPConstantProp/pthreads.ll
  llvm/test/Transforms/Attributor/callbacks.ll
  llvm/test/Transforms/Attributor/heap_to_stack.ll
  llvm/test/Transforms/Attributor/noalias.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71617.235285.patch
Type: text/x-patch
Size: 13145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191225/b224a4fb/attachment.bin>


More information about the llvm-commits mailing list