[PATCH] D71047: [LV][NFC] Keep dominator tree up to date during vectorization.

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 25 04:45:18 PST 2019


xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.cpp:514
+  DT->changeImmediateDominator(LoopExitBB, LoopLatchBB);
+  assert(DT->verify(DominatorTree::VerificationLevel::Fast));
 }
----------------
ebrevnov wrote:
> xbolva00 wrote:
> > #ifdef EXPENSIVE_CHECKS?
> Please note, in the original code there is an unconditional verification at the end of 'updateAnalysis'. Since 'updateAnalysis' was removed we need to do verification here to preserve original behavior. I'm not sure if it makes  sense to change that...
Ok, thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71047/new/

https://reviews.llvm.org/D71047





More information about the llvm-commits mailing list