[PATCH] D71799: [Attributor] AAUndefinedBehavior: Check for branches on undef value.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 24 20:45:49 PST 2019


jdoerfert added a comment.

In D71799#1795734 <https://reviews.llvm.org/D71799#1795734>, @baziotis wrote:

> - Small changes.
>
>   @uenoku please update me if you want something changed. Also, after this diff I was planning to make another to use `AAValueSimplify` in the other instructions as well. If you can, update me whether it's better to do it here.
>
>   Oh, also whether I should wait for https://reviews.llvm.org/D71852 to be committed.


I'd wait wrt. AAValueSimplify.
I'd do the following two first:

1. UnreachableInst is UB (though no need to replace it in the manifest.
2. Given an instruction, determine if that instruction or one later that is known to be executed is known to cause UB. We then hook that up to the AAIsDead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71799/new/

https://reviews.llvm.org/D71799





More information about the llvm-commits mailing list