[PATCH] D71862: [WinEH] Delete addFnAttr("no-frame-pointer-elim") which seems no longer needed

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: pengfei, rnk.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

It was added in rL238619 <https://reviews.llvm.org/rL238619>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71862

Files:
  llvm/lib/Target/X86/X86WinEHState.cpp


Index: llvm/lib/Target/X86/X86WinEHState.cpp
===================================================================
--- llvm/lib/Target/X86/X86WinEHState.cpp
+++ llvm/lib/Target/X86/X86WinEHState.cpp
@@ -179,11 +179,6 @@
                       {Int8PtrType, Type::getInt32Ty(TheModule->getContext())},
                       /*isVarArg=*/true));
 
-  // Disable frame pointer elimination in this function.
-  // FIXME: Do the nested handlers need to keep the parent ebp in ebp, or can we
-  // use an arbitrary register?
-  F.addFnAttr("no-frame-pointer-elim", "true");
-
   emitExceptionRegistrationRecord(&F);
 
   // The state numbers calculated here in IR must agree with what we calculate


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71862.235238.patch
Type: text/x-patch
Size: 691 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191225/46c83d1e/attachment.bin>