[PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 24 03:56:11 PST 2019


ikudrin added inline comments.


================
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp:60
+    llvm::Error error = set.extract(debug_aranges_data, &offset);
+    if (!error)
+      return error;
----------------
@zturner, this probably should be
```
if (error)
  return std::move(error);
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59381/new/

https://reviews.llvm.org/D59381





More information about the llvm-commits mailing list