[PATCH] D70972: [AIX] Make sure we use export lists for plugins

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:917
+set(LLVM_EXPORT_SYMBOLS_FOR_PLUGINS_default OFF)
+if (${CMAKE_SYSTEM_NAME} MATCHES "AIX" AND NOT (BUILD_SHARED_LIBS OR LLVM_LINK_LLVM_DYLIB))
+  set(LLVM_EXPORT_SYMBOLS_FOR_PLUGINS_default ON)
----------------
hubert.reinterpretcast wrote:
> I'm not too sure about this. Are differing defaults based on other options passed on the initial configuration a good CMake design?
This is done in some other places in HandleLLVMOptions. That said, I believe using CMakeDependentOption to hide the option on platforms where we set it internally maybe be a better solution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70972/new/

https://reviews.llvm.org/D70972