[PATCH] D71841: [FPEnv] Default NoFPExcept SDNodeFlag to false

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 12:23:14 PST 2019


uweigand added a comment.

Another thing I forgot to mention: I've had to add a bit of code to the X86 target to set NoFPExcept flags.  This is because you're using the same opcodes for both strict and non-strict compares, and adding the NoFPExcept in the non-strict avoids some codegen regressions we'd otherwise see.

I think a cleaner solution may be to use different opcodes for the two cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71841/new/

https://reviews.llvm.org/D71841





More information about the llvm-commits mailing list