[PATCH] D71832: [TypePromotion] Make TypeSize a class member

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 23 09:54:50 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good as far as removing the global goes.



================
Comment at: llvm/lib/CodeGen/TypePromotion.cpp:966-967
   for (BasicBlock &BB : F) {
     auto &Insts = BB.getInstList();
     for (auto &I : Insts) {
       if (AllVisited.count(&I))
----------------
Unrelated nit: Why not `for (auto &I : BB)`? The instruction list is a bit of an implementation detail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71832/new/

https://reviews.llvm.org/D71832





More information about the llvm-commits mailing list