[PATCH] D71830: [OpenMP] Reusable OpenMP context/traits handling

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D71830#1794920 <https://reviews.llvm.org/D71830#1794920>, @JonChesterfield wrote:

> Big patch but looks like a net decrease in complexity. Please could you clang format the areas phabricator is complaining about?


I'll go over it. (FWIW, I do clang format my patch automatically on each save but sometimes I want to minimize the change and only commit affected lines instead of reformatting the surrounding, e.g., a switch. Also, some of the lint warnings are not good, e.g., the `set_is_strict_subset` one.) I'll also add tests for the new capabilities and maybe Gunit tests for the lib/Frontend parts.

> Reading through on a browser looks great. I'll take a closer look in a real editor once Christmas is out of the way. Thanks for posting this.

It is a reusable, very generic approach with almost all context selector sets, selectors, and properties. So while there is a net increase in lines, a lot of them are in OMPContext.{h,cpp} with little complexity or able to handle more than we could (e.g., the scoring).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71830/new/

https://reviews.llvm.org/D71830