[PATCH] D71817: Fix LLVM tool --version build mode printing for MSVC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 22 14:03:46 PST 2019


MaskRay added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:2443
+# if defined(__OPTIMIZE__)
+#  define LLVM_IS_DEBUG_BUILD 0
+# else
----------------
`LLVM_IS_OPTIMIZED_BUILD` looks like more appropriate?
I thought the difference is between "optimized/non-optimized builds", not between "debug/non-debug builds".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71817/new/

https://reviews.llvm.org/D71817





More information about the llvm-commits mailing list