[PATCH] D71808: [Tools] Fixes -Wrange-loop-analysis warnings

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 22 09:06:58 PST 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with a request to drop top-level `const`s.



================
Comment at: llvm/tools/llvm-exegesis/lib/Clustering.cpp:255
   assert(ClusterIdForPoint_.size() == Points_.size() && "size mismatch");
-  for (const auto &Point : zip(Points_, ClusterIdForPoint_)) {
+  for (const auto Point : zip(Points_, ClusterIdForPoint_)) {
     const ClusterId &ClusterIdOfPoint = std::get<1>(Point);
----------------
Drop top-level `const` here and elsewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71808/new/

https://reviews.llvm.org/D71808





More information about the llvm-commits mailing list