[PATCH] D68765: [Attributor] Function signature rewrite infrastructure

Sun Dec 22 06:09:57 PST 2019

uenoku accepted this revision.
uenoku added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5684
+
+    // Rewire the arguments.
+    auto OldFnArgIt = OldFn->arg_begin();
----------------
nit: Rewrite

================
Comment at: llvm/test/Transforms/Attributor/ArgumentPromotion/reserve-tbaa.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --scrub-attributes
 ; RUN: opt -S -passes='attributor' -aa-pipeline='basic-aa' -attributor-disable=false -attributor-max-iterations-verify -attributor-max-iterations=2 < %s | FileCheck %s
----------------
jdoerfert wrote:
> uenoku wrote:
> > Could you explain what occurs in this test?
> So the intent was to make sure we keep tbaa metadata properly attached to the new loads and stores.
> I changed it because it was not using one of the arguments (transitively). As a result, we would
> deleted the argument with this patch but that is not what we want to test. So I added a transitive user to ensure tbaa metadata are still tested (once we actually promote the arguments).
It makes sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68765/new/

https://reviews.llvm.org/D68765