[PATCH] D71627: [Clang FE, SystemZ] Recognize -mrecord-mcount CL option.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 22 01:40:26 PST 2019


uweigand added a comment.

In D71627#1794108 <https://reviews.llvm.org/D71627#1794108>, @MaskRay wrote:

> Fixed by 0792ef72564071f21b727d0de3a14d565950290f <https://reviews.llvm.org/rG0792ef72564071f21b727d0de3a14d565950290f>. My Linux powerpc64le build is good now.
>
> `make ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- CC=~/llvm/Release/bin/clang LD=~/llvm/Release/bin/ld.lld O=out/powerpc64le powernv_defconfig zImage.epapr -j 30`


Thank for you the fix, and sorry for the disruption!

There is another limitation of the current implementation: -mrecord-mcount / -mnop-mcount are only supported with -mfentry, not with the "regular" mcount profiling.   This is just a limitation of the current implementation (but in any case, the Linux kernel build will only use it in this combination anyway).

We currently have checks that this combination is specified, but those are also in the code generator.  Should they be moved to the driver as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71627/new/

https://reviews.llvm.org/D71627





More information about the llvm-commits mailing list