[PATCH] D71565: Make mangled_names.test and update_cc_test_checks.py work with Python 2.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 21 17:29:55 PST 2019


MaskRay added inline comments.


================
Comment at: llvm/utils/update_cc_test_checks.py:1
-#!/usr/bin/env python3
+#!/usr/bin/env python
 '''A utility to update LLVM IR CHECK lines in C/C++ FileCheck test files.
----------------
thakis wrote:
> MaskRay wrote:
> > MaskRay wrote:
> > > I am concerned of the shebang change. https://lists.llvm.org/pipermail/llvm-dev/2019-December/137695.html
> > Everything else looks good to me.
> This makes the script look like every other python in the script. How is that a cause for concern?
Many Python scripts in `llvm/utils` use `#!/usr/bin/env python3` as the shebang now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71565/new/

https://reviews.llvm.org/D71565





More information about the llvm-commits mailing list