[PATCH] D71787: [Attributor] UB Attribute now handles all instructions that access memory through a pointer

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis marked an inline comment as done.
baziotis added a comment.

> LGTM. I'll commit them soon. You can continue on top if you find the time and motivation.

Great, I'll continue with branches. Could you please answer this question:

Question: `getPointerOperand()` (meaning, Attributor's `getPointerOperand()`) returns `nullptr` if the instruction is volatile. Why?
Guess: Because if it is volatile, we don't want to do any transformation to it.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2013
 
       // A load is considered UB only if it dereferences a constant
       // null pointer.
----------------
sstefan1 wrote:
> nit: I think you should update these comments (line 2021) as well.
Yep, I missed that. I'm uploading a new diff, thanks again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71787/new/

https://reviews.llvm.org/D71787