[PATCH] D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor

Fri Dec 20 21:13:33 PST 2019

lhames added a comment.

In D71683#1793698 <https://reviews.llvm.org/D71683#1793698>, @myhsu wrote:

> In D71683#1793661 <https://reviews.llvm.org/D71683#1793661>, @lhames wrote:
>
> > Actually, are you seeing this bug on ORC? Or just on MCJIT?
>
>
> ORC, specifically ORCv2.

Oh -- That's an ORCv2 bug. I have fixed that in 9f4f237e29e7 <https://reviews.llvm.org/rG9f4f237e29e7150dfcf04ae78fa287d2dc8d48e2>. Would you be able to apply that patch to your branch and see if it fixes your issue?

> So I did see a new EHFrameRegistraPlugin that will deregistrate EH frame. However, I didn’t see any usage of that class other than llvm-jitlink utility. Will that plugin be the mandatory component for EH in the future?

Yes. Though it will usually be set up for you implicitly. The plugin is only used by ObjectLinkingLayer (which is based on JITLink). RTDyldObjectLinkingLayer will continue to manage eh-frames via the memory manager.

- Lang.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71683/new/

https://reviews.llvm.org/D71683