[PATCH] D71737: [CMake][runtimes] Skip the generic target variable if named matches

[James Nagurne via Phabricator via llvm-commits]

JamesNagurne added a comment.

This foreach loop goes over each variable, yes?
If so, then I'm not sure this change does what is required.

If the list variableNames is:

RUNTIMES_target+multi_XYZ
RUNTIMES_target_XYZ

This loop will:

1. variableName = RUNTIMES_target+multi_XYZ
2. Check if {name} matches, it does
3. Add -DXYZ=value to the list
4. variableName = RUNTIMES_target_XYZ
5. Check if {name} matches, it doesn't
6. Else, check if {target} matches, it does
7. Add -DXYZ=value to the list, overriding the expected value in 3 above

Edit: That is to say, only one path will ever be executed per iteration of this loop, so the addition of else() doesn't change the behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71737/new/

https://reviews.llvm.org/D71737