[PATCH] D70450: [AArch64] Teach Load/Store optimizier to rename store operands for pairing.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:897
+                assert(MOP.isImplicit() ||
+                       (MOP.isRenamable() && !MOP.isEarlyClobber()) &&
+                           "Need renamable operands");
----------------
dancgr wrote:
> This creates a warning when compiling in debug mode for me.
> 
> Did you mean to use this?
> ```
> assert(MOP.isImplicit() ||
>                        (MOP.isRenamable() && !MOP.isEarlyClobber()) &&
>                            "Need renamable operands");
> ```
> It looks like this code is missing brackets wrapping the logical condition, like the ones from from line 886 assertion.
> 
thanks for the note, it looks like someone just fixed that in commit dc03b960d0236c18ed4382cea7bb3eb49329ed04


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70450/new/

https://reviews.llvm.org/D70450