[PATCH] D71753: [test][llvm-dwarfdump] Add missing checks for table dumping

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: ikudrin, dblaikie, JDevlieghere, MaskRay, probinson.
Herald added a project: LLVM.

Some of the tables in debug_line_malformed.s were not being checked in the NONFATAL checks in debug_line_invalid.test (only the warnings coming from them were being checked). This made the test harder to follow. Additionally, a later change will change the way the errors are handled such that more of the line table will be printed. That will require checks for these tables (or something equivalent) so that the difference in behaviour can be observed. This patch adds checks for the three tables that were missing checks.

Depends on D71752 <https://reviews.llvm.org/D71752>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71753

Files:
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test


Index: llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
===================================================================
--- llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
+++ llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
@@ -98,8 +98,22 @@
 ## Case 8: Very short prologue length for V5 (ends during parameters).
 # NONFATAL: debug_line[0x00000183]
 # NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
 
-## TODO: Add checks here for remaining tables.
+## Case 9: V5 prologue ends during file table.
+# NONFATAL: debug_line[0x000001be]
+# NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
+
+## Case 10: V5 prologue ends during directory table.
+# NONFATAL: debug_line[0x000001f9]
+# NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
+
+## Case 11: V5 invalid MD5 hash form.
+# NONFATAL: debug_line[0x00000234]
+# NONFATAL-NEXT: Line table prologue
+# NONFATAL-NOT:  Address
 
 # NONFATAL: debug_line[0x00000271]
 # NONFATAL-NOT: debug_line[{{.*}}]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71753.234866.patch
Type: text/x-patch
Size: 1020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191220/2274ed84/attachment.bin>