[PATCH] D70756: llvm-symbolizer: support DW_FORM_loclistx locations.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Sorry, I think my previous comment came out wrong. I'm happy with this going in without my approval. I just don't want to be marked as approving something that I don't really agree with (I do see your point of view to be clear - this isn't me stubbornly digging in my heels and saying you're all wrong).

I do agree that a clearer way of generating DWARF would  be nice. Gtest unit tests may be the way forward in many situations, since you can easily write some simple framework to do the common stuff and build on that (see the existing DWARFDebugLine ones for an example of what I mean). I'm not suggesting it's always appropriate mind you.

I did stumble across a dwarf2yaml version of obj2yaml. I haven't looked into it beyond that it's currently used by the mach-o version of obj2yaml, and I have no idea if yaml2obj works with it or not at this point, but it might provide a starting point for the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70756/new/

https://reviews.llvm.org/D70756