[PATCH] D71732: Move the sysroot attribute from DIModule to DICompileUnit

[Adrian Prantl via Phabricator via llvm-commits]

aprantl created this revision.
aprantl added reviewers: teemperor, friss, JDevlieghere, dblaikie.
aprantl added a project: debug-info.
Herald added a reviewer: deadalnix.
Herald added subscribers: ormris, hiraditya.
Herald added a project: LLVM.

This addresses point 1 of  PR44213. (https://bugs.llvm.org/show_bug.cgi?id=44213).

The DW_AT_LLVM_sysroot attribute is used for Clang module debug info, to allow LLDB to import a Clang module from source. Currently it is part of each DW_TAG_module, however, it is the same for all modules in a compile unit. It is more efficient and less ambiguous to store it once in the DW_TAG_compile_unit.

This should have no effect on DWARF consumers other than LLDB.


https://reviews.llvm.org/D71732

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/test/CodeGen/debug-nvptx.c
  clang/test/Modules/debug-info-moduleimport.m
  llvm/bindings/go/llvm/dibuilder.go
  llvm/include/llvm-c/DebugInfo.h
  llvm/include/llvm/IR/DIBuilder.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  llvm/lib/IR/AsmWriter.cpp
  llvm/lib/IR/DIBuilder.cpp
  llvm/lib/IR/DebugInfo.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/lib/IR/LLVMContextImpl.h
  llvm/test/Assembler/dicompileunit.ll
  llvm/test/Assembler/dimodule.ll
  llvm/test/Bindings/llvm-c/debug_info.ll
  llvm/test/CodeGen/X86/load-combine-dbg.ll
  llvm/test/DebugInfo/X86/DIModule.ll
  llvm/test/DebugInfo/X86/DIModuleContext.ll
  llvm/test/DebugInfo/X86/clang-module.ll
  llvm/tools/llvm-c-test/debuginfo.c
  llvm/unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71732.234801.patch
Type: text/x-patch
Size: 46448 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191220/21954408/attachment.bin>