[PATCH] D70756: llvm-symbolizer: support DW_FORM_loclistx locations.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

In D70756#1790896 <https://reviews.llvm.org/D70756#1790896>, @jhenderson wrote:

> I've got no more comments, but I'm not going to LGTM it because I disagree with the principle of not minimising test cases (I have better things to do with my time than try to understand what is actually important in a test case that has started failing/needs updating etc etc).


I understand your concern. But by minimizing the test case, I (not an expert in dwarf by any measure) can make it invalid in a way that is not detected by the current parser code. How do you feel about fixing a bunch of tests, all broken in different ways, when LLVM becomes smarter about it? This test case may be a bit long, but I'm reasonably sure that it is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70756/new/

https://reviews.llvm.org/D70756