[PATCH] D71668: [llvm-symbolizer] Support reading options from environment

Thu Dec 19 12:13:41 PST 2019

phosek added a comment.

In D71668#1790886 <https://reviews.llvm.org/D71668#1790886>, @jhenderson wrote:

> I like the idea, but the behaviour needs adding to the llvm-symbolizer command guide. You may also want to consider adding it to the section on differences in llvm-addr2line.

Done. While looking through command guide, I noticed that lit uses `LIT_OPTS` for the same purpose, do you have any preference between `LLVM_SYMBOLIZER_OPTIONS` and `LLVM_SYMBOLIZER_OPTS`? lit is the only precedence I found in LLVM, other tools seem to be using `OPTS` as well, e.g. `MAKE_OPTS` or `SPHINXOPTS`.

> (Requesting changes due to this issue - if it's fixed after tonight UK time, I'm okay for somebody else to LGTM and you to commit it then, as Friday is my last day in the office before the New Year).

================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:294
+      argc, argv, IsAddr2Line ? "llvm-addr2line\n" : "llvm-symbolizer\n",
+      /*Errs=*/nullptr, IsAddr2Line ? nullptr : "LLVM_SYMBOLIZER_OPTIONS");

----------------
jhenderson wrote:
> I'd be inclined to allow llvm-addr2line to read LLVM_ADDR2LINE_OPTIONS. There's no particular reason we should restrict this feature to llvm-symbolizer. We can enhance GNU's feature set safely here, I think.
That's fine with me if we're OK extending the addr2line feature set.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71668/new/

https://reviews.llvm.org/D71668