[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

[Jin Lin via Phabricator via llvm-commits]

jinlin added a comment.

In D71219#1776158 <https://reviews.llvm.org/D71219#1776158>, @steven_wu wrote:

> Breaking part the meta data sounds like a good idea. You will probably need to combine the value in the backend to generate the field in the object file.
>
> Also, please add test case. If you go down the route of splitting the value, you need:
>
> - codegen tests for correct value in the object file
> - llvm-link tests for combining objc and swift bitcode
> - auto upgrade test if you want to support the old bitcode


Steven,

1. I will add a  llvm-link tests for combining objc and swift bitcode.
2. What do you mean by "codegen tests for correct value in the object file"? There is no "object file" in the picture. Are you asking for a test that checks the value in the output of llvm-link?
3. Let us keep the auto upgrade to a different future diff to keep each diff self contained. Is that ok?

-Jin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71219/new/

https://reviews.llvm.org/D71219