[PATCH] D71495: [SelectionDAG] Copy FP flags when visiting a binary instruction.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 11:13:04 PST 2019


spatel added a comment.

In D71495#1791522 <https://reviews.llvm.org/D71495#1791522>, @mcberg2017 wrote:

> When I looked at this recently as well, it looked like intersect was were we lost our flags.


Thanks. I don't see much downside to the fix as proposed currently, but let me know if you agree. If we take the flags from the IR instruction here, it will probably be redundant with the propagation in visit(). Or we can pull that flags copying to line 3128 and avoid intersecting flags so much. I doubt this makes any difference to overall codegen time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71495/new/

https://reviews.llvm.org/D71495





More information about the llvm-commits mailing list