[PATCH] D69077: [gicombiner] Add the MatchDag structure and parse instruction DAG's from the input

[Eric Christopher via llvm-commits]

I have no idea :)

Everything is working fine now so thanks!

-eric

On Thu, Dec 19, 2019 at 8:41 AM Daniel Sanders <daniel_l_sanders at apple.com>
wrote:

> Hmm, in that case I'm not entirely sure why it wasn't working for you.
> Enabling asserts should have caused the --debug option to exist. I thought
> for a moment that LLVM_OPTIMIZED_TABLEGEN might be involved but while that
> build lacks the --debug option (asserts doesn't seem to be passed down to
> the native build), it appears we don't run the tests on the native tablegen
> so that wouldn't explain it.
>
> On 18 Dec 2019, at 21:36, Eric Christopher <echristo at gmail.com> wrote:
>
> It was a release+asserts build for me.
>
> And weird.
>
> -eric
>
> On Wed, Dec 18, 2019 at 4:19 AM Daniel Sanders <daniel_l_sanders at apple.com>
> wrote:
>
>> Was that in a release build by any chance?
>>
>> By the way, phabricator doesn't seem to import your replies for some
>> reason even though it did for all the other replies. Not sure what's going
>> on there.
>>
>> On 18 Dec 2019, at 01:29, Eric Christopher <echristo at gmail.com> wrote:
>>
>> FWIW this is the error I was seeing locally as well.
>>
>> -eric
>>
>> On Tue, Dec 17, 2019 at 4:59 PM Petr Hosek via Phabricator via
>> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>>> phosek added a comment.
>>>
>>> We're seeing a different failure on our 2-stage bots (in second stage):
>>>
>>>
>>> /b/s/w/ir/k/llvm-project/llvm/test/TableGen/GICombinerEmitter/parse-match-pattern.td:30:17:
>>> error: CHECK-LABEL: expected string not found in input
>>>   // CHECK-LABEL: Parsed rule defs/match for 'trivial'
>>>                   ^
>>>   <stdin>:1:1: note: scanning from here
>>>   llvm-tblgen: for the -d option: may not occur within a group!
>>>   ^
>>>   <stdin>:3:11: note: possible intended match here
>>>   llvm-tblgen: Did you mean '-d'?
>>>             ^
>>>
>>>
>>> Repository:
>>>   rG LLVM Github Monorepo
>>>
>>> CHANGES SINCE LAST ACTION
>>>   https://reviews.llvm.org/D69077/new/
>>>
>>> https://reviews.llvm.org/D69077
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191219/3a764735/attachment.html>