[PATCH] D71705: [cmake] Add dependency on llvm-dwarfdump to llvm-locstats

[David Spickett via Phabricator via llvm-commits]

DavidSpickett marked an inline comment as done.
DavidSpickett added a comment.

In D71705#1791232 <https://reviews.llvm.org/D71705#1791232>, @djtodoro wrote:

> Please make sure the tool name is `llvm-locstats` instead of `llvm-covstat`.


Done.



================
Comment at: llvm/utils/llvm-locstats/CMakeLists.txt:12
     )
+  if (NOT LLVM_BUILD_UTILS)
+    set_target_properties(llvm-locstats PROPERTIES EXCLUDE_FROM_ALL ON)
----------------
djtodoro wrote:
> Please describe, once again, why you decided to use the `LLVM_BUILD_UTILS` instead of the `LLVM_BUILD_TOOLS` here.
I was testing both and got confused along the way. LLVM_BUILD_TOOLS is what I intended.

Reasoning being that though llvm-locstats requires llvm-dwarfdump, it would be a bigger problem to start building llvm-dwarfdump when LLVM_BUILD_TOOLS is OFF, than it is to not build llvm-locstats when LLVM_BUILD_UTILS is ON.

(from the point of view of someone trying to trim their build time)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71705/new/

https://reviews.llvm.org/D71705