[PATCH] D71702: [DebugInfo] Relax some checking in the debug line parser

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 07:03:42 PST 2019


jhenderson added a comment.

In D71702#1791172 <https://reviews.llvm.org/D71702#1791172>, @ikudrin wrote:

> It looks like `lld/test/ELF/undef.s` comes here by accident, right?


Nope, it's intentional. Beacuse I've relaxed the severity of prologue errors so that the parsing can continue, LLD test no longer fails to load the line information for the undefined reference that has a slightly dodgy line table. For reference, I added the --implicit-check-not to make sure I hadn't missed anything when verifying that test still achieved its main goal. Given that LLD should only emit the bad line table information once, I think it's a worthwhile addition too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71702/new/

https://reviews.llvm.org/D71702





More information about the llvm-commits mailing list