[PATCH] D71695: [cmake] Include the llvm-locstats target when utils and tools are not being built.

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 19 06:53:54 PST 2019


DavidSpickett added a comment.

That looks good to me and it works for our use case.

Took some time to think through the BUILD_TOOLS vs BUILD_UTILS difference. I think what you have is correct. It means that with BUILD_UTILS ON "all" doesn't include llvm-locstats, but to even use it you'd need to build dwarfdump. And if we just made drawfdump build if BUILD_UTILS is on, that would certainly be unexpected given that dwarfdump is a "tool" itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71695/new/

https://reviews.llvm.org/D71695





More information about the llvm-commits mailing list