[PATCH] D71678: [ConstantHoisting] Ignore unreachable bb:s when collecting candidates

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/ConstantHoisting/X86/pr43903-not-all-uses-rebased.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -consthoist -consthoist-gep=1 -S | FileCheck %s
+
----------------
bjope wrote:
> spatel wrote:
> > Should this RUN line specify the x86 triple explicitly, or it doesn't matter? (not sure what will happen on bots that are non-x86)
> Ah thanks! I've missed to add the triple here. I'll fix that when landing this.
Actually after I posted the comment, I noticed that the triple is explicitly stated under here with "target triple".

So I don't think there's any problem, but it might be nicer to have it in the RUN line for consistency with the other test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71678/new/

https://reviews.llvm.org/D71678