[PATCH] D71611: [cmake] Add llvm-locstats to LLVM_TEST_DEPENDS

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added a comment.

How is this change supposed to interact with LLVM_BUILD_TOOLS?
"LLVM_BUILD_TOOLS: Build the LLVM tools. If OFF, just generate build targets."

We have a downstream build that sets this OFF, then builds llvm-mc only. You can reproduce the same thing with upstream llvm:

  $ cmake -G Ninja ../llvm-project/llvm/ -DLLVM_BUILD_TOOLS=OFF

  CMake Error at cmake/modules/AddLLVM.cmake:1457 (add_dependencies):
    The dependency target "llvm-locstats" of target "check-llvm-tools-llvm-rc"
    does not exist.
  Call Stack (most recent call first):
    cmake/modules/AddLLVM.cmake:1509 (add_lit_target)
    test/CMakeLists.txt:179 (add_lit_testsuites)
  <repeats for lots of targets>

Perhaps build tools isn't defining the targets as it claims.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71611/new/

https://reviews.llvm.org/D71611