[PATCH] D52634: [WebAssembly] Use TargetIndex operands in DbgValue to track WebAssembly operands locations

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:580
+  // TODO This is a target-independent but the WebAssembly-specific expression
+  // is encoded here. Is there a better way?
+  emitOp(dwarf::DW_OP_WASM_location);
----------------
aprantl wrote:
> It's also odd to generalize something for which only a single implementation exists...
I think this is called what it is because TargetIndex is already a general operand type. But maybe at the DWARF layer it really just just be something like `DwarfExpression::addWasmLocation`, and then in asmPrinter/DwarfDebug.cpp we just call `addWasmLocation` instead. If it's possible to assert there that the target is wasm, so much the better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52634/new/

https://reviews.llvm.org/D52634