[PATCH] D70756: llvm-symbolizer: support DW_FORM_loclistx locations.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

I'm sorry but I have better use for my time than editing valid dwarf files by hand.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1106
+    } else {
+      consumeError(Loc.takeError());
+    }
----------------
jhenderson wrote:
> If there's an error, we shouldn't just throw away that error ideally. However, I see that this is a `void` function so propagating the Error up the stack may be non-trivial. If that is the case, please at least comment this with a TODO to say that we should handle the Error more cleanly.
The error is handled by not setting Local.FrameOffset, which would result in llvm-symbolizer printing "??" instead of the frame offset value. AFAIK, it is valid for AT_location to not be present, and I've definitely seen such files in the wild.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70756/new/

https://reviews.llvm.org/D70756