[PATCH] D70447: [Support] ThreadPoolExecutor fixes for Windows/MinGW

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 13:13:06 PST 2019


rnk added a comment.

I guess I like the quick_exit idea. Supporting multiple shutdowns of a thread pool seems fraught with complexity.

I also think it's kind of reasonable to keep the Parallel.h APIs simple. You don't actually want to have more than one threadpool per process running at the same time, so if we were to change all the APIs to pass a context parameter, I'm not sure that'd be a good thing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70447/new/

https://reviews.llvm.org/D70447





More information about the llvm-commits mailing list