[PATCH] D71565: Make mangled_names.test and update_cc_test_checks.py work with Python 2.

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 18 12:43:55 PST 2019


arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.

Looks fine to me if @MaskRay is happy with it.



================
Comment at: llvm/test/tools/UpdateTestChecks/lit.local.cfg:20
+        (name, "'%s' %s %s" % (
+            config.python_executable, script_path, extra_args)))
 
----------------
Not related to this review, but while you are changing this line it might be good to replace the single-quoted %s: i.e.:

`(name, '%s %s %s' % (shell_quote(config.python_executable), script_path, extra_args)))`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71565/new/

https://reviews.llvm.org/D71565





More information about the llvm-commits mailing list